Skip to content

Conversation

@tnevrlka
Copy link
Member

@tnevrlka tnevrlka commented Oct 2, 2025

E2E tests in rhtap-build-tenant ran by integration-runner need view permissions for build-service.

There is a role application-manager created for konflux-integration-runner in order for E2E tests in rhtap-build-tenant namespace to have access to Applications.
Since they also need access to Components, rename the Role too.

@openshift-ci openshift-ci bot requested review from rcerven and tisutisu October 2, 2025 13:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

🤖 Gemini AI Assistant Available

Hi @tnevrlka! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

🤖 Hi @tnevrlka, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@tnevrlka tnevrlka force-pushed the integration-runner-build-perms branch from 97bf0c4 to 8ed0fbe Compare October 15, 2025 11:06
@tisutisu
Copy link
Member

/lgtm

Copy link
Member

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmorhun, tnevrlka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mmorhun
Copy link
Member

mmorhun commented Oct 16, 2025

/retest

1 similar comment
@mmorhun
Copy link
Member

mmorhun commented Oct 16, 2025

/retest

@openshift-ci openshift-ci bot removed the lgtm label Oct 16, 2025
@mmorhun
Copy link
Member

mmorhun commented Oct 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2025
E2E tests in rhtap-build-tenant ran by integration-runner need view
permissions for build-service

Signed-off-by: Tomáš Nevrlka <[email protected]>
There is a role application-manager created for
konflux-integration-runner in order for E2E tests in rhtap-build-tenant
namespace to have access to Applications.
Since they also need access to Components, rename the Role too.

Signed-off-by: Tomáš Nevrlka <[email protected]>
@tnevrlka tnevrlka force-pushed the integration-runner-build-perms branch from 20c414e to e1e7883 Compare October 16, 2025 12:02
@openshift-ci openshift-ci bot removed the lgtm label Oct 16, 2025
Signed-off-by: Tomáš Nevrlka <[email protected]>
@mmorhun
Copy link
Member

mmorhun commented Oct 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2025
@hugares hugares merged commit 2a6c32e into redhat-appstudio:main Oct 16, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants